Skip to content

marvin: add missing test data for test_migration smoketest#3106

Merged
yadvr merged 2 commits into
apache:4.11from
shapeblue:add-missing-tdata
Dec 24, 2018
Merged

marvin: add missing test data for test_migration smoketest#3106
yadvr merged 2 commits into
apache:4.11from
shapeblue:add-missing-tdata

Conversation

@yadvr

@yadvr yadvr commented Dec 19, 2018

Copy link
Copy Markdown
Member

Adds missing test data for test/integration/smoke/test_migration.py

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

This is fixed in Trillian codebase but not in cloudstack's test_data.py. Test run result:

=== TestName: test_01_native_to_native_network_migration | Status : SUCCESS ===

=== TestName: test_02_native_to_native_vpc_migration | Status : SUCCESS ===

===final results are now copied to: /tmp//MarvinLogs/test_migration_3B7NX2===

@yadvr
marvin: add missing test data for test_migration smoketest
bf5248c 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr yadvr added this to the 4.11.3.0 milestone Dec 19, 2018
@yadvr

yadvr commented Dec 20, 2018

Copy link
Copy Markdown
Member Author

/cc @borisstoyanov @PaulAngus @anuragaw @dhlaluku @nvazquez

borisstoyanov
borisstoyanov approved these changes Dec 20, 2018
View reviewed changes

@borisstoyanov borisstoyanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, is this affecting any test failure @rhtyd ?

@borisstoyanov

borisstoyanov commented Dec 20, 2018

Copy link
Copy Markdown
Contributor

just read it all, sorry :)

@yadvr
test: use test template
9de88a9 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr

yadvr commented Dec 20, 2018

Copy link
Copy Markdown
Member Author

@borisstoyanov was trying to run tests against 4.11.2.0 pkgs with the vxlan based concept CI on the side yesterday, found the issue from it.
@blueorangutan package

@blueorangutan

blueorangutan commented Dec 20, 2018

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Dec 20, 2018

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2500

@yadvr

yadvr commented Dec 20, 2018

Copy link
Copy Markdown
Member Author

@blueorangutan test

@blueorangutan

blueorangutan commented Dec 20, 2018

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Dec 20, 2018

Copy link
Copy Markdown

Trillian test result (tid-3269)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 28744 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3106-t3269-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 64 look OK, 4 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_04_extract_template Failure 128.38 test_templates.py
ContextSuite context=TestISOUsage>:setup Error 0.00 test_usage.py
test_06_download_detached_volume Failure 137.66 test_volumes.py
test_01_redundant_vpc_site2site_vpn Failure 201.59 test_vpc_vpn.py

@anuragaw

anuragaw commented Dec 24, 2018

Copy link
Copy Markdown
Contributor

Code LGTM.

@yadvr yadvr merged commit 68b4b84 into apache:4.11 Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@borisstoyanov borisstoyanov borisstoyanov approved these changes

@wido wido Awaiting requested review from wido

@rafaelweingartner rafaelweingartner Awaiting requested review from rafaelweingartner

@GabrielBrascher GabrielBrascher Awaiting requested review from GabrielBrascher

+1 more reviewer

@anuragaw anuragaw anuragaw approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component:marvin

Projects

None yet

Milestone

4.11.3.0

Development

Successfully merging this pull request may close these issues.

4 participants

@yadvr @borisstoyanov @blueorangutan @anuragaw